[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231020160329.uqgjjr6ubfrcqjkj@mercury.elektranox.org>
Date: Fri, 20 Oct 2023 18:03:29 +0200
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Conor Dooley <conor@...nel.org>
Cc: Heiko Stuebner <heiko@...ech.de>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
linux-rockchip@...ts.infradead.org, linux-usb@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, kernel@...labora.com
Subject: Re: [PATCH v4 1/3] dt-bindings: usb: add rk3588 compatible to
rockchip,dwc3
Hi Conor,
On Fri, Oct 20, 2023 at 04:36:19PM +0100, Conor Dooley wrote:
> On Fri, Oct 20, 2023 at 04:11:40PM +0200, Sebastian Reichel wrote:
> > [...]
> > +allOf:
> > + - $ref: snps,dwc3.yaml#
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: rockchip,rk3328-dwc3
> > + then:
> > + properties:
> > + clocks:
> > + minItems: 3
> > + maxItems: 4
> > + clock-names:
> > + minItems: 3
> > + items:
> > + - const: ref_clk
> > + - const: suspend_clk
> > + - const: bus_clk
> > + - const: grf_clk
>
> minItems for clocks and clock-names is already 3, is it not?
Yes, but the following 'maxItems: 4' implicitly sets it to 4,
so I had to set it again. The same is true for clock-names -
providings new 'items:' effectively drops the "minItems: 3"
from the generic section.
> Otherwise,
> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
>
> Thanks,
> Conor.
Thanks,
-- Sebastian
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists