linux-kernel - Re: [PATCH] staging: octeon: Fix warnings due to introduction of new typedefs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZTOS6eaygOA6nRKD@HP-ENVY-Notebook>
Date:   Sat, 21 Oct 2023 10:59:21 +0200
From:   Jonathan Bergh <bergh.jonathan@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: octeon: Fix warnings due to introduction of new
 typedefs

On Sat, Oct 21, 2023 at 10:32:29AM +0200, Greg KH wrote:

Hi

>  This looks like a new version of a previously submitted patch, but you
>  did not list below the --- line any changes from the previous version.

This patch is a *new* patch which replaced a previous *series* of patches
so it was considered a *new* standalone patch, rather than a new version 
of the original series. 

> - Your patch did many different things all at once, making it difficult
>   to review.  All Linux kernel patches need to only do one thing at a
>   time.  If you need to do multiple things (such as clean up all coding
>   style issues in a file/driver), do it in a sequence of patches, each
>   one doing only one thing.

This patch only addresses removal of typedefs from the declarations 
and fixes up the implmentations that relied on those typedefs. The previous
advice was to not make breaking changes across patches, so this patch 
represents code changes which are as atomic as possible in a single patch
without breaking the build. It does not mix formatting / other changes
with the code change.