linux-kernel - Re: [PATCH] tools/nolibc: Add Linux specific waitpid() flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <633402b0-7167-465f-99c6-d959b5f48073@t-8ch.de>
Date:   Sat, 21 Oct 2023 11:00:20 +0200 (GMT+02:00)
From:   Thomas Weißschuh  <thomas@...ch.de>
To:     Mark Brown <broonie@...nel.org>
Cc:     Willy Tarreau <w@....eu>,
        Thomas Weißschuh <linux@...ssschuh.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools/nolibc: Add Linux specific waitpid() flags

Hi,

Oct 20, 2023 23:57:01 Mark Brown <broonie@...nel.org>:

> Linux defines a few custom flags for waitpid(), make them available to
> nolibc based programs.
>
> Signed-off-by: Mark Brown <broonie@...nel.org>
> ---
> tools/include/nolibc/types.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tools/include/nolibc/types.h b/tools/include/nolibc/types.h
> index 8cfc4c860fa4..801ea0bb186e 100644
> --- a/tools/include/nolibc/types.h
> +++ b/tools/include/nolibc/types.h
> @@ -109,7 +109,10 @@
> #define WIFSIGNALED(status) ((status) - 1 < 0xff)
>
> /* waitpid() flags */
> -#define WNOHANG      1
> +#define WNOHANG      0x00000001
> +#define __WNOTHREAD  0x20000000
> +#define __WALL       0x40000000
> +#define __WCLONE     0x80000000

Wouldn't it be easier to include linux/wait.h instead?

In general quite a few defines from types.h
are actually copies from UAPI headers.

>
> /* standard exit() codes */
> #define EXIT_SUCCESS 0
>
> ---
> base-commit: 6465e260f48790807eef06b583b38ca9789b6072
> change-id: 20231020-nolibc-waitpid-flags-80ac075ab978
>
> Best regards,
> --
> Mark Brown <broonie@...nel.org>