linux-kernel - Re: [PATCH 03/11] ARM: dts: qcom: Update devicetree for ADC7 rename for QCOM PMICs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 Oct 2023 11:39:40 +0530
From:   Jishnu Prakash <quic_jprakash@...cinc.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        <agross@...nel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linus.walleij@...aro.org>,
        <Jonathan.Cameron@...wei.com>, <sboyd@...nel.org>,
        <dmitry.baryshkov@...aro.org>, <quic_subbaram@...cinc.com>,
        <quic_collinsd@...cinc.com>, <quic_kamalw@...cinc.com>,
        <marijn.suijten@...ainline.org>,
        <andriy.shevchenko@...ux.intel.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        <cros-qcom-dts-watchers@...omium.org>,
        <linux-arm-msm@...r.kernel.org>
CC:     <linux-iio@...r.kernel.org>, <linux-arm-msm-owner@...r.kernel.org>
Subject: Re: [PATCH 03/11] ARM: dts: qcom: Update devicetree for ADC7 rename
 for QCOM PMICs

Hi Krzysztof,

On 7/9/2023 10:48 PM, Krzysztof Kozlowski wrote:
> On 08/07/2023 09:28, Jishnu Prakash wrote:
>> The name "ADC7" needs to be replaced with the name "ADC5_GEN2"
>> everywhere to match the convention used for these ADC peripherals
>> on Qualcomm Technologies, Inc. PMICs. Update devicetree files for
> We do not rename compatibles to match convention. Please provide proper
> rationale.

I'll avoid renaming the compatible directly, will just mark it 
deprecated - but is it fine to do the other changes, for updating the 
macro names used in devicetree (replacing the ADC7 macros with the ADC5 
Gen2 macros)?

I do see an example of a macro change in devicetree done in this patch: 
https://lore.kernel.org/all/cover.1646388139.git.zong.li@sifive.com/.

Patch 2 here replaced some macro definitions: 
https://lore.kernel.org/all/f9284873c2993a9952d9fe4f8dd5e89f20daab75.1646388139.git.zong.li@sifive.com/.

Patch 3 made the corresponding update in devicetree files: 
https://lore.kernel.org/all/db92d209fa700f7da8bc8028083476fcc138d80e.1646388139.git.zong.li@sifive.com/. 

 From this mail, it looks like the maintainer was willing to pick them 
at that time: 
https://lore.kernel.org/all/20220315225652.CDAD1C340E8@smtp.kernel.org/, 
would something similar be possible here?

Thanks,

Jishnu