linux-kernel - Re: [PATCH 04/11] iio: adc: Update bindings to remove support for ADC7 name used on QCOM PMICs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dcbab235-3510-9e8e-5f08-7b8241a71688@quicinc.com>
Date:   Mon, 23 Oct 2023 11:41:21 +0530
From:   Jishnu Prakash <quic_jprakash@...cinc.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        <agross@...nel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linus.walleij@...aro.org>,
        <Jonathan.Cameron@...wei.com>, <sboyd@...nel.org>,
        <dmitry.baryshkov@...aro.org>, <quic_subbaram@...cinc.com>,
        <quic_collinsd@...cinc.com>, <quic_kamalw@...cinc.com>,
        <quic_jestar@...cinc.com>, <marijn.suijten@...ainline.org>,
        <andriy.shevchenko@...ux.intel.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        "Daniel Lezcano" <daniel.lezcano@...aro.org>,
        Amit Kucheria <amitk@...nel.org>,
        "Zhang Rui" <rui.zhang@...el.com>, Luca Weiss <luca@...tu.xyz>,
        <linux-iio@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-pm@...r.kernel.org>
CC:     <linux-arm-msm-owner@...r.kernel.org>
Subject: Re: [PATCH 04/11] iio: adc: Update bindings to remove support for
 ADC7 name used on QCOM PMICs

Hi Krzysztof,

On 7/9/2023 10:49 PM, Krzysztof Kozlowski wrote:
> On 08/07/2023 09:28, Jishnu Prakash wrote:
>> Now that usage of "ADC7" name has been replaced with usage of "ADC5
>> Gen2" name everywhere, remove all support for "ADC7" name.
> Why?

The idea is to replace usage of the name "ADC7" with "ADC5 Gen2" 
everywhere possible, to match our internal convention and align better 
with the "ADC5 Gen3" support I'm adding in this patch series - is it 
better if I just update documentation and dtbindings directly in one 
patch for ADC5 Gen2 and update devicetree in one patch after that for 
the corresponding macro changes?


>
>
>> @@ -26,7 +26,6 @@ properties:
>>             - qcom,spmi-vadc
>>             - qcom,spmi-adc5
>>             - qcom,spmi-adc-rev2
>> -          - qcom,spmi-adc7
> NAK. You did not explained why dropping existing compatible is correct,
> expected and okay.
>
> Also:
>
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching.
>
>
>
> Best regards,
> Krzysztof

Yes, I'll avoid dropping the compatible, I'll just mark it deprecated as 
Jonathan suggested, in a single bindings patch without having separate 
patches for adding and removing support.

Will make sure to check subject prefixes too.

Thanks,

Jishnu