[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231023095855.GH8909@google.com>
Date: Mon, 23 Oct 2023 10:58:55 +0100
From: Lee Jones <lee@...nel.org>
To: André Apitzsch <git@...tzsch.eu>
Cc: Samuel Holland <samuel@...lland.org>, Pavel Machek <pavel@....cz>,
linux-leds@...r.kernel.org, Chen-Yu Tsai <wens@...e.org>,
Jernej Skrabec <jernej.skrabec@...il.com>,
Albert Ou <aou@...s.berkeley.edu>,
Conor Dooley <conor@...nel.org>, Guo Ren <guoren@...nel.org>,
Heiko Stuebner <heiko.stuebner@...ll.eu>,
Heiko Stuebner <heiko@...ech.de>,
Jisheng Zhang <jszhang@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Palmer Dabbelt <palmer@...belt.com>,
Paul Walmsley <paul.walmsley@...ive.com>,
Philipp Zabel <p.zabel@...gutronix.de>,
Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-riscv@...ts.infradead.org, linux-sunxi@...ts.linux.dev
Subject: Re: [RESEND PATCH v7 2/5] leds: sun50i-a100: New driver for the A100
LED controller
> Hi Samuel,
>
> there are two more things to change, which came up recently. See below.
>
> Regards,
> André
>
> Am Samstag, dem 31.12.2022 um 17:55 -0600 schrieb Samuel Holland:
> > Some Allwinner sunxi SoCs, starting with the A100, contain an LED
> > controller designed to drive RGB LED pixels. Add a driver for it
> > using
> > the multicolor LED framework, and with LEDs defined in the device
> > tree.
> >
> > Acked-by: Jernej Skrabec <jernej.skrabec@...il.com>
> > Signed-off-by: Samuel Holland <samuel@...lland.org>
> > ---
> > [...]
> > diff --git a/drivers/leds/leds-sun50i-a100.c b/drivers/leds/leds-
> > sun50i-a100.c
[...]
> > +struct sun50i_a100_ledc {
> > + struct device *dev;
> > + void __iomem *base;
> > + struct clk *bus_clk;
> > + struct clk *mod_clk;
> > + struct reset_control *reset;
> > +
> > + u32 *buffer;
> > + struct dma_chan *dma_chan;
> > + dma_addr_t dma_handle;
> > + int pio_length;
> > + int pio_offset;
> > +
> > + spinlock_t lock;
> > + int next_length;
> > + bool xfer_active;
> > +
> > + u32 format;
> > + struct sun50i_a100_ledc_timing timing;
> > +
> > + int num_leds;
> > + struct sun50i_a100_ledc_led leds[];
>
> Annotate struct with __counted_by(num_leds).
André, please remember to snip your replies.
--
Lee Jones [李琼斯]
Powered by blists - more mailing lists