linux-kernel - Re: [PATCH] Input: cyttsp5 - improve error handling and remove regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202310231838.JHHtGKmB-lkp@intel.com>
Date:   Mon, 23 Oct 2023 18:35:05 +0800
From:   kernel test robot <lkp@...el.com>
To:     James Hilliard <james.hilliard1@...il.com>,
        linux-input@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev,
        James Hilliard <james.hilliard1@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: cyttsp5 - improve error handling and remove regmap

Hi James,

kernel test robot noticed the following build warnings:

[auto build test WARNING on dtor-input/next]
[also build test WARNING on dtor-input/for-linus hid/for-next linus/master v6.6-rc7 next-20231023]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/James-Hilliard/Input-cyttsp5-improve-error-handling-and-remove-regmap/20231023-165327
base:   https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
patch link:    https://lore.kernel.org/r/20231023085234.105572-1-james.hilliard1%40gmail.com
patch subject: [PATCH] Input: cyttsp5 - improve error handling and remove regmap
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231023/202310231838.JHHtGKmB-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231023/202310231838.JHHtGKmB-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310231838.JHHtGKmB-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/input/touchscreen/cyttsp5.c: In function 'cyttsp5_get_hid_descriptor':
>> drivers/input/touchscreen/cyttsp5.c:684:22: warning: unused variable 'reg' [-Wunused-variable]
     684 |         unsigned int reg = HID_DESC_REG;
         |                      ^~~


vim +/reg +684 drivers/input/touchscreen/cyttsp5.c

   677	
   678	static int cyttsp5_get_hid_descriptor(struct cyttsp5 *ts,
   679					      struct cyttsp5_hid_desc *desc)
   680	{
   681		struct device *dev = ts->dev;
   682		u8 cmd[2] = { 0 };
   683		int rc;
 > 684		unsigned int reg = HID_DESC_REG;
   685	
   686		put_unaligned_le16(HID_DESC_REG, cmd);
   687	
   688		rc = cyttsp5_write(ts, HID_DESC_REG, cmd, 2);
   689		if (rc) {
   690			dev_err(dev, "Failed to get HID descriptor, rc=%d\n", rc);
   691			return rc;
   692		}
   693	
   694		rc = wait_for_completion_interruptible_timeout(&ts->cmd_done,
   695				msecs_to_jiffies(CY_HID_GET_HID_DESCRIPTOR_TIMEOUT_MS));
   696		if (rc <= 0) {
   697			dev_err(ts->dev, "HID get descriptor timed out\n");
   698			rc = -ETIMEDOUT;
   699			return rc;
   700		}
   701	
   702		memcpy(desc, ts->response_buf, sizeof(*desc));
   703	
   704		/* Check HID descriptor length and version */
   705		if (le16_to_cpu(desc->hid_desc_len) != sizeof(*desc) ||
   706		    le16_to_cpu(desc->bcd_version) != HID_VERSION) {
   707			dev_err(dev, "Unsupported HID version\n");
   708			return -ENODEV;
   709		}
   710	
   711		return 0;
   712	}
   713	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki