linux-kernel - Re: [PATCH v1 3/5] soc: qcom: memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c8cc463-84dd-4f28-812d-f5eea922daef@linaro.org>
Date:   Mon, 23 Oct 2023 14:53:48 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Zhenhua Huang <quic_zhenhuah@...cinc.com>, agross@...nel.org,
        andersson@...nel.org, konrad.dybcio@...aro.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org
Cc:     linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...cinc.com,
        quic_tingweiz@...cinc.com
Subject: Re: [PATCH v1 3/5] soc: qcom: memory_dump: Add memory dump driver

On 23/10/2023 14:19, Zhenhua Huang wrote:
> 
> 
> On 2023/10/23 19:46, Krzysztof Kozlowski wrote:
>> On 23/10/2023 13:43, Zhenhua Huang wrote:
>>>>> +
>>>>> +			mem_dump_apply_offset(&dump_vaddr, &phys_addr,
>>>>> +					      size + QCOM_DUMP_DATA_SIZE);
>>>>> +			if (phys_addr > phys_end_addr) {
>>>>> +				dev_err_probe(dev, -ENOMEM, "Exceeding allocated region\n");
>>>>
>>>> ENOMEM? Does not look right then.
>>>
>>> ENOMEM means the memory allocated not enough? any suggestion? Thanks.
>>
>> The error code is okay, but we rarely need to print error messages for
>> memory allocation failures. Core prints it already.
> 
> It's not same as below case. Allocation is successful here, while the 
> driver used more than allocated size.

$ man errno
ENOMEM means: Not enough space/cannot allocate memory


Best regards,
Krzysztof