linux-kernel - Re: [for-next][PATCH 5/6] tracing: Move readpos from seq_buf to trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231023104341.34c188a5@gandalf.local.home>
Date:   Mon, 23 Oct 2023 10:43:41 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Kees Cook <keescook@...omium.org>,
        Justin Stitt <justinstitt@...gle.com>,
        Kent Overstreet <kent.overstreet@...ux.dev>,
        Petr Mladek <pmladek@...e.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        Christoph Hellwig <hch@....de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [for-next][PATCH 5/6] tracing: Move readpos from seq_buf to
 trace_seq

On Mon, 23 Oct 2023 12:57:53 +0300
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> On Fri, Oct 20, 2023 at 06:27:18PM -0400, Steven Rostedt wrote:
> > From: "Matthew Wilcox (Oracle)" <willy@...radead.org>
> > 
> > To make seq_buf more lightweight as a string buf, move the readpos member
> > from seq_buf to its container, trace_seq.  That puts the responsibility
> > of maintaining the readpos entirely in the tracing code.  If some future
> > users want to package up the readpos with a seq_buf, we can define a
> > new struct then.  
> 
> > Link: https://lore.kernel.org/linux-trace-kernel/20231020033545.2587554-2-willy@infradead.org
> >   
> 
> If we want Link: to be recognized as a tag, we probably should remove the blank
> line. Maybe new versions of b4 support that, but not all maintainers use it and
> AFAIK the convention was to have no blank lines in the tag block.
> 

So I've been using Link tags for over a decade. I originally had it as
part of the tag block, but realized that it's more for humans than bots,
and purposely separated it out. What Link tags are good for IMO is for
humans that are looking at git blame and want to know more content. I
prefer the Link tag to stand out so that it's easier for humans to go back
to the archive and see if there was more discussions about why the change
was made.

Hence, I don't really care if Link tags are "recognized" by anything but
humans. It's actually one of the first tags to show up after Signed-off-by:
Cc: and Acked-by:. I believe it even predates "Fixes". At least the new
format for the Fixes tag.

-- Steve