[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231024-bobbed-although-06f341259ebb@spud>
Date: Tue, 24 Oct 2023 16:17:16 +0100
From: Conor Dooley <conor@...nel.org>
To: Hsin-Yi Wang <hsinyi@...omium.org>
Cc: Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
NĂcolas F . R . A . Prado
<nfraprado@...labora.com>,
Bernhard Rosenkränzer <bero@...libre.com>,
Frank Wunderlich <frank-w@...lic-files.de>,
Macpaul Lin <macpaul.lin@...iatek.com>,
Sean Wang <sean.wang@...iatek.com>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 3/6] dt-bindings: arm64: dts: mediatek: Add
mt8183-kukui-jacuzzi-makomo
On Mon, Oct 23, 2023 at 05:02:26PM -0700, Hsin-Yi Wang wrote:
> Add makomo sku0 and sku1 which uses different audio codec.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@...omium.org>
> ---
> Documentation/devicetree/bindings/arm/mediatek.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index fe8c488a3207..b131e0bdbf01 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -250,6 +250,18 @@ properties:
> - google,kodama-sku32
> - const: google,kodama
> - const: mediatek,mt8183
> + - description: Google Makomo (Lenovo 100e Chromebook 2nd Gen MTK 2)
> + items:
> + - const: google,makomo-rev4-sku0
> + - const: google,makomo-rev5-sku0
With these bindings, how does one describe a makomo-rev5-sku0?
What you have here is only suitable for describing the makomo-rev4-sku0.
Cheers,
Conor.
> + - const: google,makomo
> + - const: mediatek,mt8183
> + - description: Google Makomo (Lenovo 100e Chromebook 2nd Gen MTK 2)
> + items:
> + - const: google,makomo-rev4-sku1
> + - const: google,makomo-rev5-sku1
> + - const: google,makomo
> + - const: mediatek,mt8183
> - description: Google Willow (Acer Chromebook 311 C722/C722T)
> items:
> - enum:
> --
> 2.42.0.758.gaed0368e0e-goog
>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists