linux-kernel - Re: [PATCH 6/6] arm64: dts: mt8183: Add jacuzzi pico/pico6 board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53e9351a-87ca-42f1-b0a5-624c1fd86623@linaro.org>
Date:   Tue, 24 Oct 2023 17:21:09 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Hsin-Yi Wang <hsinyi@...omium.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Nícolas F . R . A . Prado 
        <nfraprado@...labora.com>,
        Bernhard Rosenkränzer <bero@...libre.com>,
        Frank Wunderlich <frank-w@...lic-files.de>,
        Macpaul Lin <macpaul.lin@...iatek.com>,
        Sean Wang <sean.wang@...iatek.com>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 6/6] arm64: dts: mt8183: Add jacuzzi pico/pico6 board

On 24/10/2023 02:02, Hsin-Yi Wang wrote:
> pico is also known as Acer Chromebook Spin 311.
> 
> Signed-off-by: Hsin-Yi Wang <hsinyi@...omium.org>
> ---

...

> +&wifi_pwrseq {
> +	post-power-on-delay-ms = <50>;
> +
> +	/* Toggle WIFI_ENABLE to reset the chip. */
> +	reset-gpios = <&pio 8 1>;

Use proper defines.

> +};
> +
> +&wifi_pins_pwrseq {
> +	pins_wifi_enable {

No underscores in node names.

Best regards,
Krzysztof