linux-kernel - Re: [PATCH v2 1/2] wifi: ath11k: fix temperature event locking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZTfUswqVkAgJvnye@hovoldconsulting.com>
Date:   Tue, 24 Oct 2023 16:29:07 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Kalle Valo <kvalo@...nel.org>
Cc:     Johan Hovold <johan+linaro@...nel.org>,
        Jeff Johnson <quic_jjohnson@...cinc.com>,
        ath11k@...ts.infradead.org, linux-wireless@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v2 1/2] wifi: ath11k: fix temperature event locking

On Tue, Oct 24, 2023 at 04:59:35PM +0300, Kalle Valo wrote:
> Johan Hovold <johan+linaro@...nel.org> writes:
> 
> > The ath11k active pdevs are protected by RCU but the temperature event
> > handling code calling ath11k_mac_get_ar_by_pdev_id() was not marked as a
> > read-side critical section as reported by RCU lockdep:

> On what hardware and firmware version did you test this? As there's so
> many different combos we use Tested-on tag to provide that information
> in the commit message:
> 
> https://wireless.wiki.kernel.org/en/users/drivers/ath11k/submittingpatches#tested-on_tag
> 
> I can add that if you let me know what you used.

I hit this on the Lenovo Thinkpad X13s and I guess the tag should be:

Tested-on: QCNFA765 hw2.1 WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.23

Note that I've only been able to test the ath11k fixes (not the
corresponding ath12k) and I only tested this particular patch fully
(e.g. since I didn't trigger any radar events).

Johan