linux-kernel - Re: [PATCH v3] ima: detect changes to the backing overlay file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <145a91c7044c08928646f65850a518febcf5a5ca.camel@linux.ibm.com>
Date:   Wed, 25 Oct 2023 11:09:28 -0400
From:   Mimi Zohar <zohar@...ux.ibm.com>
To:     Raul Rangel <rrangel@...omium.org>
Cc:     linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org,
        Eric Snowberg <eric.snowberg@...cle.com>,
        Amir Goldstein <amir73il@...il.com>
Subject: Re: [PATCH v3] ima: detect changes to the backing overlay file

On Wed, 2023-10-25 at 08:59 -0600, Raul Rangel wrote:
> On Wed, Oct 25, 2023 at 8:39 AM Mimi Zohar <zohar@...ux.ibm.com> wrote:
> > +               if (!IS_I_VERSION(backing_inode) ||
> > +                   backing_inode->i_sb->s_dev != iint->real_dev ||
> > +                   backing_inode->i_ino != iint->real_ino ||
> > +                   !inode_eq_iversion(backing_inode, iint->version)) {
> > +                       iint->flags &= ~IMA_DONE_MASK;
> > +                       iint->measured_pcrs = 0;
> > +               }
> > +       }
> > +
> Does this mean I need to mount ext4 with `-o iversion`? Or has it been
> enabled by default?

According to commit 1ff20307393e ("ext4: unconditionally enable the
i_version counter")  it's now enabled by default.
> 
> I can test this patch out sometime this week and verify it fixes the
> performance regression.
> 
> Thanks!

Much appreciated!

-- 
thanks,

Mimi