lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 25 Oct 2023 21:16:21 +0300
From:   Adrian Hunter <>
To:     Jisheng Zhang <>,
        Drew Fustini <>
Cc:     Ulf Hansson <>,
        Rob Herring <>,
        Krzysztof Kozlowski <>,
        Conor Dooley <>,
        Guo Ren <>, Fu Wei <>,
        Paul Walmsley <>,
        Palmer Dabbelt <>,
        Albert Ou <>,
        Conor Dooley <>,
        Robert Nelson <>,
        Jason Kridner <>,
        Xi Ruoyao <>, Han Gao <>,
        Icenowy Zheng <>,,,,
Subject: Re: [PATCH v3 2/7] mmc: sdhci: add __sdhci_execute_tuning() to header

On 25/10/23 18:29, Jisheng Zhang wrote:
> On Mon, Oct 23, 2023 at 02:07:03PM -0700, Drew Fustini wrote:
>> Expose __sdhci_execute_tuning() so that it can be called from the
>> mmc host controller drivers.
>> In the sdhci-of-dwcmshc driver, sdhci_dwcmshc_th1520_ops sets
>> platform_execute_tuning to th1520_execute_tuning(). That function has
> Hi Drew,
> Just FYI, my th1520 version patch in my local repo overrides the
> mmc_host_ops.execute_tuning as the following:
> host->mmc_host_ops.execute_tuning = dwcmshc_execute_tuning;
> In dwcmshc_execute_tuning(), I will do some necessary setting then
> call sdhci_execute_tuning();
> So I don't need to export __sdhci_execute_tuning(). The main reason
> is that the __abc symbol is expected to be used internally. However,
> I have no big preference. I would leave the decision be made by
> mmc maintainers @Ulf @Adrian, can you please comment?

It is OK.  We try to consider SDHCI as more of a library, so
sharing any reasonably well-defined function is OK.

Powered by blists - more mailing lists