linux-kernel - Re: [PATCH] hwmon: HS3001: remove redundant store on division

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6a943960-d283-44e5-b19c-0250d6f4bed8@roeck-us.net>
Date:   Wed, 25 Oct 2023 12:00:20 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     Andre Werner <andre.werner@...tec-electronic.com>,
        Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: HS3001: remove redundant store on division

On Mon, Oct 23, 2023 at 02:58:28PM +0100, Colin Ian King wrote:
> Currently the local variable hum is being divided by a constant and
> the results is being re-assigned back to hum before the value is being
> returned to the caller. The assignment to hum is redundant and can
> be removed.
> 
> Cleans up clang scan build warning:
> drivers/hwmon/hs3001.c:65:9: warning: Although the value stored to 'hum'
> is used in the enclosing expression, the value is never actually read
> from 'hum' [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Applied.

Guenter