[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5726b2d1-e130-d84f-4a2a-30db3095d215@quicinc.com>
Date: Wed, 25 Oct 2023 13:45:46 +0530
From: Mukesh Ojha <quic_mojha@...cinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Neil Armstrong <neil.armstrong@...aro.org>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Wesley Cheng <quic_wcheng@...cinc.com>
CC: <linux-arm-msm@...r.kernel.org>, <linux-usb@...r.kernel.org>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: usb: qcom,dwc3: document the SM8560
SuperSpeed DWC3 USB controller
On 10/25/2023 1:37 PM, Krzysztof Kozlowski wrote:
> On 25/10/2023 09:25, Neil Armstrong wrote:
>> Document the SuperSpeed DWC3 USB controller on the SM8650 Platform.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>
Typo here as well, sm8650.
>> ---
>> For convenience, a regularly refreshed linux-next based git tree containing
>> all the SM8650 related work is available at:
>> https://git.codelinaro.org/neil.armstrong/linux/-/tree/topic/sm85650/upstream/integ
>> ---
>> Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
>> index e889158ca205..ea2c663ddc52 100644
>> --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
>> +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
>> @@ -46,6 +46,7 @@ properties:
>> - qcom,sm8350-dwc3
>> - qcom,sm8450-dwc3
>> - qcom,sm8550-dwc3
>> + - qcom,sm8650-dwc3
>> - const: qcom,dwc3
>
> I think you miss two dedicated entries in allOf:if:then for clocks and
> interrupts.
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists