linux-kernel - Re: [PATCH v2 1/2] wifi: ath11k: fix temperature event locking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <169822797640.891844.4871182636116201125.kvalo@kernel.org>
Date:   Wed, 25 Oct 2023 09:59:37 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     Johan Hovold <johan+linaro@...nel.org>
Cc:     Jeff Johnson <quic_jjohnson@...cinc.com>,
        ath11k@...ts.infradead.org, linux-wireless@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Johan Hovold <johan+linaro@...nel.org>, stable@...r.kernel.org
Subject: Re: [PATCH v2 1/2] wifi: ath11k: fix temperature event locking

Johan Hovold <johan+linaro@...nel.org> wrote:

> The ath11k active pdevs are protected by RCU but the temperature event
> handling code calling ath11k_mac_get_ar_by_pdev_id() was not marked as a
> read-side critical section as reported by RCU lockdep:
> 
>         =============================
>         WARNING: suspicious RCU usage
>         6.6.0-rc6 #7 Not tainted
>         -----------------------------
>         drivers/net/wireless/ath/ath11k/mac.c:638 suspicious rcu_dereference_check() usage!
> 
>         other info that might help us debug this:
> 
>         rcu_scheduler_active = 2, debug_locks = 1
>         no locks held by swapper/0/0.
>         ...
>         Call trace:
>         ...
>          lockdep_rcu_suspicious+0x16c/0x22c
>          ath11k_mac_get_ar_by_pdev_id+0x194/0x1b0 [ath11k]
>          ath11k_wmi_tlv_op_rx+0xa84/0x2c1c [ath11k]
>          ath11k_htc_rx_completion_handler+0x388/0x510 [ath11k]
> 
> Mark the code in question as an RCU read-side critical section to avoid
> any potential use-after-free issues.
> 
> Tested-on: WCN6855 hw2.1 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.23
> 
> Fixes: a41d10348b01 ("ath11k: add thermal sensor device support")
> Cc: stable@...r.kernel.org      # 5.7
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> Acked-by: Jeff Johnson <quic_jjohnson@...cinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@...cinc.com>

2 patches applied to ath-next branch of ath.git, thanks.

1a5352a81b47 wifi: ath11k: fix temperature event locking
3b6c14833165 wifi: ath11k: fix dfs radar event locking

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20231019153115.26401-2-johan+linaro@kernel.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches