linux-kernel - Re: [PATCH v2] drm/logicvc: Kconfig: select REGMAP and REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 25 Oct 2023 12:11:55 +0200
From:   Paul Kocialkowski <paul.kocialkowski@...tlin.com>
To:     Sui Jingfeng <suijingfeng@...ngson.cn>
Cc:     David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drm/logicvc: Kconfig: select REGMAP and REGMAP_MMIO

Hi,

On Tue 20 Jun 23, 11:56, Sui Jingfeng wrote:
> Hi,
> 
> On 2023/6/8 15:15, Paul Kocialkowski wrote:
> > Hi,
> > 
> > On Thu 08 Jun 23, 10:42, Sui Jingfeng wrote:
> > > drm/logicvc driver is depend on REGMAP and REGMAP_MMIO, should select this
> > > two kconfig option, otherwise the driver failed to compile on platform
> > > without REGMAP_MMIO selected:
> > > 
> > > ERROR: modpost: "__devm_regmap_init_mmio_clk" [drivers/gpu/drm/logicvc/logicvc-drm.ko] undefined!
> > > make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
> > > make: *** [Makefile:1978: modpost] Error 2
> > > 
> > > Signed-off-by: Sui Jingfeng <suijingfeng@...ngson.cn>
> > Thanks for the fix, looks good to me!
> > 
> > Acked-by: Paul Kocialkowski <paul.kocialkowski@...tlin.com>
> 
> Thanks a lot,
> 
> Please don't forget to push this to drm-misc or drm-tip if you has the time,
> as (even though trivial) it's precious for me.

So I totally forgot about this and only pushed it to drm-misc-fixes now.
Sincere apologies for this.

Thanks again for spotting this issue and submitting the fix.

Paul

> 
> 
> > Cheers,
> > 
> > Paul
> > 
> > > ---
> > >   drivers/gpu/drm/logicvc/Kconfig | 2 ++
> > >   1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/drivers/gpu/drm/logicvc/Kconfig b/drivers/gpu/drm/logicvc/Kconfig
> > > index fa7a88368809..1df22a852a23 100644
> > > --- a/drivers/gpu/drm/logicvc/Kconfig
> > > +++ b/drivers/gpu/drm/logicvc/Kconfig
> > > @@ -5,5 +5,7 @@ config DRM_LOGICVC
> > >   	select DRM_KMS_HELPER
> > >   	select DRM_KMS_DMA_HELPER
> > >   	select DRM_GEM_DMA_HELPER
> > > +	select REGMAP
> > > +	select REGMAP_MMIO
> > >   	help
> > >   	  DRM display driver for the logiCVC programmable logic block from Xylon
> > > -- 
> > > 2.25.1
> > > 
> -- 
> Jingfeng
> 

-- 
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)