[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231025110140.2034650-1-dario.binacchi@amarulasolutions.com>
Date: Wed, 25 Oct 2023 13:01:31 +0200
From: Dario Binacchi <dario.binacchi@...rulasolutions.com>
To: linux-kernel@...r.kernel.org
Cc: Dario Binacchi <dario.binacchi@...rulasolutions.com>,
Joerg Roedel <joro@...tes.org>,
Jonathan Hunter <jonathanh@...dia.com>,
Krishna Reddy <vdumpa@...dia.com>,
Robin Murphy <robin.murphy@....com>,
Thierry Reding <thierry.reding@...il.com>,
Will Deacon <will@...nel.org>, iommu@...ts.linux.dev,
linux-tegra@...r.kernel.org
Subject: [PATCH] iommu/tegra-smmu: fix error checking for debugfs_create_dir()
The return value of debugfs_create_dir() should be checked using the
IS_ERR() function.
Signed-off-by: Dario Binacchi <dario.binacchi@...rulasolutions.com>
---
drivers/iommu/tegra-smmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c
index e445f80d0226..cd1d80c4c673 100644
--- a/drivers/iommu/tegra-smmu.c
+++ b/drivers/iommu/tegra-smmu.c
@@ -1056,7 +1056,7 @@ DEFINE_SHOW_ATTRIBUTE(tegra_smmu_clients);
static void tegra_smmu_debugfs_init(struct tegra_smmu *smmu)
{
smmu->debugfs = debugfs_create_dir("smmu", NULL);
- if (!smmu->debugfs)
+ if (IS_ERR(smmu->debugfs))
return;
debugfs_create_file("swgroups", S_IRUGO, smmu->debugfs, smmu,
--
2.42.0
Powered by blists - more mailing lists