lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1acd75d0-67a7-4a17-99c7-707cca305f37@linux.intel.com> Date: Wed, 25 Oct 2023 19:25:50 +0800 From: Baolu Lu <baolu.lu@...ux.intel.com> To: Dario Binacchi <dario.binacchi@...rulasolutions.com>, linux-kernel@...r.kernel.org Cc: baolu.lu@...ux.intel.com, Joerg Roedel <joro@...tes.org>, Jonathan Hunter <jonathanh@...dia.com>, Krishna Reddy <vdumpa@...dia.com>, Robin Murphy <robin.murphy@....com>, Thierry Reding <thierry.reding@...il.com>, Will Deacon <will@...nel.org>, iommu@...ts.linux.dev, linux-tegra@...r.kernel.org Subject: Re: [PATCH] iommu/tegra-smmu: fix error checking for debugfs_create_dir() On 2023/10/25 19:01, Dario Binacchi wrote: > The return value of debugfs_create_dir() should be checked using the > IS_ERR() function. > > Signed-off-by: Dario Binacchi <dario.binacchi@...rulasolutions.com> > --- > > drivers/iommu/tegra-smmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c > index e445f80d0226..cd1d80c4c673 100644 > --- a/drivers/iommu/tegra-smmu.c > +++ b/drivers/iommu/tegra-smmu.c > @@ -1056,7 +1056,7 @@ DEFINE_SHOW_ATTRIBUTE(tegra_smmu_clients); > static void tegra_smmu_debugfs_init(struct tegra_smmu *smmu) > { > smmu->debugfs = debugfs_create_dir("smmu", NULL); > - if (!smmu->debugfs) > + if (IS_ERR(smmu->debugfs)) > return; This check can be removed, as debugfs_create_file() can handle the case where @parent is an error pointer. > > debugfs_create_file("swgroups", S_IRUGO, smmu->debugfs, smmu, Best regards, baolu
Powered by blists - more mailing lists