linux-kernel - Re: [Patch v4 01/11] dt-bindings: media: s5p-mfc: Add mfcv12 variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <948af111-e7a1-4757-a784-b4256657abd6@linaro.org>
Date:   Wed, 25 Oct 2023 15:00:11 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Aakarsh Jain <aakarsh.jain@...sung.com>,
        linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Cc:     m.szyprowski@...sung.com, andrzej.hajda@...el.com,
        mchehab@...nel.org, hverkuil-cisco@...all.nl,
        krzysztof.kozlowski+dt@...aro.org, dillon.minfei@...il.com,
        david.plowman@...pberrypi.com, mark.rutland@....com,
        robh+dt@...nel.org, conor+dt@...nel.org,
        linux-samsung-soc@...r.kernel.org, andi@...zian.org,
        gost.dev@...sung.com, alim.akhtar@...sung.com,
        aswani.reddy@...sung.com, pankaj.dubey@...sung.com,
        ajaykumar.rs@...sung.com, linux-fsd@...la.com
Subject: Re: [Patch v4 01/11] dt-bindings: media: s5p-mfc: Add mfcv12 variant

On 25/10/2023 12:22, Aakarsh Jain wrote:
> Add Tesla FSD MFC(MFC v12) compatible.
> 
> Cc: linux-fsd@...la.com
> Signed-off-by: Aakarsh Jain <aakarsh.jain@...sung.com>
> ---

No changelog and your cover letter does not explain what happened here.
Specifically, why did you decide to ignore received tag.

>  .../bindings/media/samsung,s5p-mfc.yaml          | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml b/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml
> index 084b44582a43..c30eb309f670 100644
> --- a/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml
> +++ b/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml
> @@ -24,6 +24,7 @@ properties:
>            - samsung,mfc-v7                # Exynos5420
>            - samsung,mfc-v8                # Exynos5800
>            - samsung,mfc-v10               # Exynos7880
> +          - tesla,fsd-mfc                 # Tesla FSD
>        - items:
>            - enum:
>                - samsung,exynos3250-mfc    # Exynos3250
> @@ -165,6 +166,21 @@ allOf:
>            minItems: 1
>            maxItems: 2
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - tesla,fsd-mfc
> +    then:
> +      properties:
> +        clocks:
> +          maxItems: 1
> +        clock-names:
> +          items:
> +            - const: mfc
> +        iommus: false

That's odd. How so? MFC v12 does not support IOMMU?

Best regards,
Krzysztof