linux-kernel - Re: [PATCH 00/10] staging: rtl8192e: Convert array rx_ring[] to rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 26 Oct 2023 10:09:52 +0300
From:   Dan Carpenter <dan.carpenter@...aro.org>
To:     Philipp Hortmann <philipp.g.hortmann@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/10] staging: rtl8192e: Convert array rx_ring[] to
 rx_ring

On Thu, Oct 26, 2023 at 07:43:26AM +0200, Philipp Hortmann wrote:
> Remove some functions that always return false or zero.
> Remove a loop that is always executed one time and convert arrays to variables.
> Remove some unused constants.
> 
> Tested with rtl8192e (WLL6130-D99) in Mode n (12.5 MB/s)
> Transferred this patch over wlan connection of rtl8192e.
> 
> Philipp Hortmann (10):
>   staging: rtl8192e: Remove HTIOTActIsDisableMCS14()
>   staging: rtl8192e: Remove HTIOTActIsDisableMCS15()
>   staging: rtl8192e: Remove HTIOTActIsDisableMCSTwoSpatialStream()
>   staging: rtl8192e: Remove HTIOTActIsDisableEDCATurbo()
>   staging: rtl8192e: Remove loops with constant MAX_RX_QUEUE
>   staging: rtl8192e: Convert array rx_ring[] to variable rx_ring
>   staging: rtl8192e: Convert array rx_buf[][] to array rx_buf[]
>   staging: rtl8192e: Convert array rx_ring_dma[] to variable rx_ring_dma
>   staging: rtl8192e: Convert array rx_idx[] to variable rx_idx
>   staging: rtl8192e: Remove unused constants starting with MAX_RX_QUEUE
> 

Looks good to me.

Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>

regards,
dan carpenter