linux-kernel - RE: [EXT] Re: [PATCH v6 07/11] firmware: imx: add driver for NXP EdgeLock Enclave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DU2PR04MB86305DF657B0809B754F6F1895DDA@DU2PR04MB8630.eurprd04.prod.outlook.com>
Date:   Thu, 26 Oct 2023 11:18:00 +0000
From:   Pankaj Gupta <pankaj.gupta@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "clin@...e.com" <clin@...e.com>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "pierre.gondois@....com" <pierre.gondois@....com>,
        "festevam@...il.com" <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Gaurav Jain <gaurav.jain@....com>,
        "alexander.stein@...tq-group.com" <alexander.stein@...tq-group.com>,
        Varun Sethi <V.Sethi@....com>
Subject: RE: [EXT] Re: [PATCH v6 07/11] firmware: imx: add driver for NXP
 EdgeLock Enclave



> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Wednesday, October 4, 2023 12:11 PM
> To: Pankaj Gupta <pankaj.gupta@....com>; shawnguo@...nel.org;
> s.hauer@...gutronix.de; kernel@...gutronix.de; clin@...e.com;
> conor+dt@...nel.org; pierre.gondois@....com; festevam@...il.com; dl-
> linux-imx <linux-imx@....com>; davem@...emloft.net;
> robh+dt@...nel.org; krzysztof.kozlowski+dt@...aro.org; linux-arm-
> kernel@...ts.infradead.org; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org; Gaurav Jain <gaurav.jain@....com>;
> alexander.stein@...tq-group.com; Varun Sethi <V.Sethi@....com>
> Subject: [EXT] Re: [PATCH v6 07/11] firmware: imx: add driver for NXP
> EdgeLock Enclave
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On 27/09/2023 19:53, Pankaj Gupta wrote:
> > The Edgelock Enclave , is the secure enclave embedded in the SoC to
> > support the features like HSM, SHE & V2X, using message based
> > communication channel.
> >
> > ELE FW communicates on a dedicated MU with application core where
> > kernel is running. It exists on specific i.MX processors. e.g.
> > i.MX8ULP, i.MX93.
> >
> > Signed-off-by: Pankaj Gupta <pankaj.gupta@....com>
> 
> Where is the user-space tool? Please include it in the commit msg. We talked
> about this already.
> 
It is included as part of "Documentation/ABI/testing/se-cdev".
I will add it in the commit message too.

> > ---
> >  Documentation/ABI/testing/se-cdev         |   41 +
> >  drivers/firmware/imx/Kconfig              |   12 +
> 
> 
> ...
> 
> > +
> > +     ret = ele_mu_request_channel(dev, &priv->rx_chan,
> > +                                  &priv->ele_mb_cl, info->mbox_rx_name);
> > +     if (ret) {
> > +             if (ret != -EPROBE_DEFER)
> > +                     dev_err(dev, "Failed to request rx channel\n");
> > +
> > +             goto exit;
> > +     }
> > +
> > +     priv->ctxs = devm_kzalloc(dev, sizeof(dev_ctx) * priv->max_dev_ctx,
> > +                               GFP_KERNEL);
> > +
> > +     if (!priv->ctxs) {
> > +             ret = -ENOMEM;
> > +             dev_err(dev, "Fail allocate mem for private
> > + dev-ctxs.\n");
> 
> So you ignored the feedback... I assume you ignored it all, so:
> 
> NAK
> 
> Please go back and implement the feedback.
I will remove the dev_err prints for memory allocations.
If still needed, will convert the dev_err to dev_dbg.

> 
> Best regards,
> Krzysztof