linux-kernel - RE: [EXT] Re: [PATCH v6 02/11] dt-bindings: arm: fsl: add imx-se-fw binding doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Oct 2023 11:23:08 +0000
From:   Pankaj Gupta <pankaj.gupta@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Rob Herring <robh@...nel.org>
CC:     "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "clin@...e.com" <clin@...e.com>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "pierre.gondois@....com" <pierre.gondois@....com>,
        "festevam@...il.com" <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Gaurav Jain <gaurav.jain@....com>,
        "alexander.stein@...tq-group.com" <alexander.stein@...tq-group.com>,
        Varun Sethi <V.Sethi@....com>
Subject: RE: [EXT] Re: [PATCH v6 02/11] dt-bindings: arm: fsl: add imx-se-fw
 binding doc



> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Wednesday, October 4, 2023 12:06 PM
> To: Pankaj Gupta <pankaj.gupta@....com>; Rob Herring <robh@...nel.org>
> Cc: shawnguo@...nel.org; s.hauer@...gutronix.de;
> kernel@...gutronix.de; clin@...e.com; conor+dt@...nel.org;
> pierre.gondois@....com; festevam@...il.com; dl-linux-imx <linux-
> imx@....com>; davem@...emloft.net; krzysztof.kozlowski+dt@...aro.org;
> linux-arm-kernel@...ts.infradead.org; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org; Gaurav Jain <gaurav.jain@....com>;
> alexander.stein@...tq-group.com; Varun Sethi <V.Sethi@....com>
> Subject: Re: [EXT] Re: [PATCH v6 02/11] dt-bindings: arm: fsl: add imx-se-fw
> binding doc
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On 04/10/2023 06:10, Pankaj Gupta wrote:
> 
> >>
> >>> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> >>> +
> >>> +required:
> >>> +  - compatible
> >>> +  - mboxes
> >>> +  - mbox-names
> >>> +  - fsl,mu-id
> >>
> >> How is memory-region optional?
> > Depending on the type of enclave IP and the FW, memory-region is
> configured optionally.
> > For i.MX8ULP and i.MX93, it is required. For i.MX8DXL, it is not required.
> 
> Then write it in the bindings in allOf:if:then:.
Accepted.

> 
> >>
> >>> +
> >>> +additionalProperties: false
> >>> +
> >>> +examples:
> >>> +  - |
> >>> +    ele_fw: se-fw {
> >>
> >> Drop unused labels.
> > I am sorry, if I am not able to understand your point here.
> > But, all the below labels are getting used.
> > I can remove the fsl,mu-id. Will do it in V7.
> 
> Comment was about labels, not properties.
The label "ele_fw", is needed to be placed in different DTSI file.

For instance, node is added in i.mx93.dtsi.
Using label, the memory-region property dependent on size of DDR on the platform, is placed in:

- imx93-11x11-evk.dts
 

> 
> Best regards,
> Krzysztof