linux-kernel - Re: [PATCH 2/3] LoongArch: Add RSEQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0e0cbc68-2b4c-462d-aff4-abd795b3b63d@efficios.com>
Date:   Thu, 26 Oct 2023 14:07:28 -0400
From:   Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
To:     Huang Pei <huangpei@...ngson.cn>,
        Huacai Chen <chenhuacai@...ngson.cn>
Cc:     loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] LoongArch: Add RSEQ_SIG break code definition

On 2023-10-26 07:44, Huang Pei wrote:
> Signed-off-by: Huang Pei <huangpei@...ngson.cn>
> ---
>   arch/loongarch/include/uapi/asm/break.h | 2 ++

Why is this part of the uapi ? None of the other architecture has this 
as part of uapi. It's only defined in the rseq selftest arch-specific 
header file.

Thanks,

Mathieu

>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/loongarch/include/uapi/asm/break.h b/arch/loongarch/include/uapi/asm/break.h
> index bb9b82ba59f2..e0fcfc304834 100644
> --- a/arch/loongarch/include/uapi/asm/break.h
> +++ b/arch/loongarch/include/uapi/asm/break.h
> @@ -20,4 +20,6 @@
>   #define BRK_UPROBE_BP		12	/* See <asm/uprobes.h> */
>   #define BRK_UPROBE_XOLBP	13	/* See <asm/uprobes.h> */
>   
> +#define BRK_RSEQ_SIG		16	/* See rseq */
> +
>   #endif /* __UAPI_ASM_BREAK_H */

-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com