linux-kernel - Re: [PATCH 2/4] media: i2c: imx214: Move controls init to separate function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8332c443fe33a74774f2375009a31e7895fcf37a.camel@apitzsch.eu>
Date:   Fri, 27 Oct 2023 23:23:34 +0200
From:   André Apitzsch <git@...tzsch.eu>
To:     Ricardo Ribalda Delgado <ribalda@...nel.org>
Cc:     Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH 2/4] media: i2c: imx214: Move controls init to separate
 function

Hi Ricardo,

Am Freitag, dem 27.10.2023 um 14:25 +0200 schrieb Ricardo Ribalda
Delgado:
> Hi Andre
> On Mon, Oct 23, 2023 at 11:49 PM André Apitzsch <git@...tzsch.eu>
> wrote:
> > 
> > Code refinement, no functional changes.
> > 
> > Signed-off-by: André Apitzsch <git@...tzsch.eu>
> 
> With Jacopos comments (don't use de_err_probe())
> Reviewed-by: Ricardo Ribalda <ribalda@...omium.org>
> 
> > +       ret = imx214_ctrls_init(imx214);
> > +       if (ret < 0)
> >                 goto free_ctrl;
> 
> It seems like we can mutex_destroy a non inited mutex. Could you send
> a follow-up patch to fix that?
> 
Sorry, I don't get it. Could you explain what you mean. Thanks.

> Thanks!