linux-kernel - Re: [PATCH 2/4] media: i2c: imx214: Move controls init to separate function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 28 Oct 2023 08:44:01 +0200
From:   Ricardo Ribalda Delgado <ribalda@...nel.org>
To:     André Apitzsch <git@...tzsch.eu>
Cc:     Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH 2/4] media: i2c: imx214: Move controls init to separate function

Hi André

On Fri, Oct 27, 2023 at 11:23 PM André Apitzsch <git@...tzsch.eu> wrote:
>
> Hi Ricardo,
>
> Am Freitag, dem 27.10.2023 um 14:25 +0200 schrieb Ricardo Ribalda
> Delgado:
> > Hi Andre
> > On Mon, Oct 23, 2023 at 11:49 PM André Apitzsch <git@...tzsch.eu>
> > wrote:
> > >
> > > Code refinement, no functional changes.
> > >
> > > Signed-off-by: André Apitzsch <git@...tzsch.eu>
> >
> > With Jacopos comments (don't use de_err_probe())
> > Reviewed-by: Ricardo Ribalda <ribalda@...omium.org>
> >
> > > +       ret = imx214_ctrls_init(imx214);
> > > +       if (ret < 0)
> > >                 goto free_ctrl;
> >
> > It seems like we can mutex_destroy a non inited mutex. Could you send
> > a follow-up patch to fix that?
> >
> Sorry, I don't get it. Could you explain what you mean. Thanks.
>

If the controls are initialized incorrectly we will jump to free_ctrl
in line 1046, which calls
mutex_destroy(&imx214->mutex);

But that mutex initialized in line 1050.

You did not introduce the bug, but since you have the hardware and are
sending the other patches it would be great if you could add a new
patch to fix it :)

Thanks!


> > Thanks!
>