linux-kernel - Re: [PATCH 2/5] dt-bindings: arm: qcom: Document SC8380XP SoC and boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2cecb51e-9528-471c-8de0-cb716977c0e0@linaro.org>
Date:   Fri, 27 Oct 2023 10:16:47 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Sibi Sankar <quic_sibis@...cinc.com>, andersson@...nel.org,
        konrad.dybcio@...aro.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, catalin.marinas@....com,
        ulf.hansson@...aro.org
Cc:     agross@...nel.org, conor+dt@...nel.org, ayan.kumar.halder@....com,
        j@...nau.net, dmitry.baryshkov@...aro.org, nfraprado@...labora.com,
        m.szyprowski@...sung.com, u-kumar1@...com, peng.fan@....com,
        lpieralisi@...nel.org, quic_rjendra@...cinc.com,
        abel.vesa@...aro.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, quic_tsoni@...cinc.com,
        neil.armstrong@...aro.org
Subject: Re: [PATCH 2/5] dt-bindings: arm: qcom: Document SC8380XP SoC and
 boards

On 25/10/2023 16:24, Sibi Sankar wrote:
> From: Rajendra Nayak <quic_rjendra@...cinc.com>
> 
> Document the SC8380XP SoC binding and also the boards using it.
> Also document the new board id qcp (Qualcomm Compute Platform).
> 
> Signed-off-by: Rajendra Nayak <quic_rjendra@...cinc.com>
> Signed-off-by: Sibi Sankar <quic_sibis@...cinc.com>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 88b84035e7b1..6145e9ad340c 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -62,6 +62,7 @@ description: |
>          sc7280
>          sc8180x
>          sc8280xp
> +        sc8380xp
>          sda660
>          sdm450
>          sdm630
> @@ -110,6 +111,7 @@ description: |
>          liquid
>          rdp432-c2
>          mtp
> +        qcp
>          qrd
>          rb2
>          ride
> @@ -1044,6 +1046,12 @@ properties:
>                - qcom,sm8550-qrd
>            - const: qcom,sm8550
>  
> +      - items:
> +          - enum:
> +              - qcom,sc8380xp-crd
> +              - qcom,sc8380xp-qcp
> +          - const: qcom,sc8380xp

This is some odd placement. Please keep things properly ordered.

Best regards,
Krzysztof