linux-kernel - Re: [PATCH v5] hwmon: (pmbus/max31785) Add delay between bus accesses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <629a994a-6047-4989-8b22-c36fa7167d10@roeck-us.net>
Date:   Fri, 27 Oct 2023 08:05:09 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Lakshmi Yadlapati <lakshmiy@...ibm.com>
Cc:     joel@....id.au, andrew@...id.au, eajames@...ux.ibm.com,
        ninad@...ux.ibm.com, jdelvare@...e.com,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] hwmon: (pmbus/max31785) Add delay between bus accesses

On Thu, Oct 26, 2023 at 11:43:46PM -0500, Lakshmi Yadlapati wrote:
> The MAX31785 has shown erratic behaviour across multiple system
> designs, unexpectedly clock stretching and NAKing transactions.
> 
> Experimentation shows that this seems to be triggered by a register access
> directly back to back with a previous register write. Experimentation also
> shows that inserting a small delay after register writes makes the issue go
> away.
> 
> Use a similar solution to what the max15301 driver does to solve the same
> problem. Create a custom set of bus read and write functions that make sure
> that the delay is added.
> 
> Signed-off-by: Lakshmi Yadlapati <lakshmiy@...ibm.com>
[ ... ]
> +	if (delta < MAX31785_WAIT_DELAY_US)
> +		usleep_range(MAX31785_WAIT_DELAY_US - delta,
> +			     MAX31785_WAIT_DELAY_US);

This means the driver will now wait up to 250 uS even if it only
has to wait for 1 uS. But I really don't want to wait or argue further,
so I just applied the patch as-is.

Guenter