linux-kernel - Re: [PATCH 4/4] spi: spi-fsl-qspi: Add support for rx data sample point adjustment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 27 Oct 2023 17:07:00 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Frieder Schrempf <frieder.schrempf@...tron.de>
Cc:     kernel test robot <lkp@...el.com>, Eberhard Stoll <estl@....net>,
        Han Xu <han.xu@....com>, linux-kernel@...r.kernel.org,
        linux-spi@...r.kernel.org, oe-kbuild-all@...ts.linux.dev,
        Eberhard Stoll <eberhard.stoll@...tron.de>,
        Amit Kumar Mahapatra <amit.kumar-mahapatra@....com>,
        Amit Kumar Mahapatra via Alsa-devel 
        <alsa-devel@...a-project.org>, Michal Simek <monstr@...str.eu>,
        Rob Herring <robh@...nel.org>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Yang Yingliang <yangyingliang@...wei.com>
Subject: Re: [PATCH 4/4] spi: spi-fsl-qspi: Add support for rx data sample
 point adjustment

On Fri, Oct 27, 2023 at 08:51:49AM +0200, Frieder Schrempf wrote:
> On 26.10.23 22:03, kernel test robot wrote:

> >    drivers/spi/spi-fsl-qspi.c: In function 'fsl_qspi_select_mem':
> >>> drivers/spi/spi-fsl-qspi.c:558:38: warning: suggest parentheses around comparison in operand of '|' [-Wparentheses]
> >      558 |         if (chip->rx_sample_delay_ns != spi->rx_sample_delay_ns |
> >          |             ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~

> IIRC, when I prepared the patches for sending "checkpatch.pl --strict"
> suggested to remove the parentheses here. Seems a bit inconsistent...

Ignore chekpatch, and it does look like as well as parentheses you
should have used || not | here.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)