[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <04680b40-9d2d-403c-93af-9e91a491a053@quicinc.com>
Date: Tue, 31 Oct 2023 09:54:46 +0530
From: Kathiravan Thirumoorthy <quic_kathirav@...cinc.com>
To: Stephen Boyd <sboyd@...nel.org>, Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Catalin Marinas <catalin.marinas@....com>,
Conor Dooley <conor+dt@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Michael Turquette <mturquette@...libre.com>,
Richard Cochran <richardcochran@...il.com>,
Rob Herring <robh+dt@...nel.org>, Will Deacon <will@...nel.org>
CC: <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
<netdev@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 4/8] clk: qcom: ipq5332: add gpll0_out_aux clock
On 10/31/2023 12:27 AM, Stephen Boyd wrote:
> Quoting Kathiravan Thirumoorthy (2023-10-30 02:47:19)
>> Add support for gpll0_out_aux clock which acts as the parent for
>> certain networking subsystem (NSS) clocks.
>>
>> Signed-off-by: Kathiravan Thirumoorthy <quic_kathirav@...cinc.com>
>> ---
>> drivers/clk/qcom/gcc-ipq5332.c | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
>>
>> diff --git a/drivers/clk/qcom/gcc-ipq5332.c b/drivers/clk/qcom/gcc-ipq5332.c
>> index 235849876a9a..966bb7ca8854 100644
>> --- a/drivers/clk/qcom/gcc-ipq5332.c
>> +++ b/drivers/clk/qcom/gcc-ipq5332.c
>> @@ -87,6 +87,19 @@ static struct clk_alpha_pll_postdiv gpll0 = {
>> },
>> };
>>
>> +static struct clk_alpha_pll_postdiv gpll0_out_aux = {
>> + .offset = 0x20000,
>> + .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_STROMER_PLUS],
>> + .width = 4,
>> + .clkr.hw.init = &(struct clk_init_data) {
>
> const initdata
Thanks for pointing it out. Some of the clock structure doesn't have the
"const" qualifier. Will fix all those in V2.
>
>> + .name = "gpll0_out_aux",
>> + .parent_hws = (const struct clk_hw *[]) {
>> + &gpll0_main.clkr.hw },
>> + .num_parents = 1,
>> + .ops = &clk_alpha_pll_postdiv_ro_ops,
>> + },
>> +};
>> +
>> static struct clk_alpha_pll gpll2_main = {
>> .offset = 0x21000,
>> .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_STROMER_PLUS],
Powered by blists - more mailing lists