linux-kernel - Re: [PATCH] ARM: dts: omap4: embt2ws: add LED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 31 Oct 2023 10:16:35 +0100
From:   Pavel Machek <pavel@....cz>
To:     Andreas Kemnade <andreas@...nade.info>
Cc:     bcousson@...libre.com, tony@...mide.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: omap4: embt2ws: add LED

Hi!

> Add LED since the driver is now available.
> 
> Signed-off-by: Andreas Kemnade <andreas@...nade.info>

Is it one LED or three LEDs?

If it is one, we should use multicolor...

BR,
										Pavel
										
> @@ -206,7 +207,31 @@ &i2c3 {
>  
>  	clock-frequency = <100000>;
>  
> -	/* TODO: BD2606MVV at 0x66 */
> +	led-controller@66 {
> +		compatible = "rohm,bd2606mvv";
> +		reg = <0x66>;
> +
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		led@0 {
> +			reg = <0>;
> +			color = <LED_COLOR_ID_GREEN>;
> +			function = LED_FUNCTION_STATUS;
> +		};
> +
> +		led@2 {
> +			reg = <2>;
> +			color = <LED_COLOR_ID_BLUE>;
> +			function = LED_FUNCTION_STATUS;
> +		};
> +
> +		led@4 {
> +			reg = <4>;
> +			color = <LED_COLOR_ID_RED>;
> +			function = LED_FUNCTION_STATUS;
> +		};
> +	};
>  };
>  
>  &i2c4 {

-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)