[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231031122005.13368-1-rwahl@gmx.de>
Date: Tue, 31 Oct 2023 13:20:05 +0100
From: Ronald Wahl <rwahl@....de>
To: linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Cc: Grygorii Strashko <grygorii.strashko@...com>,
Dan Carpenter <dan.carpenter@...aro.org>,
Siddharth Vadapalli <s-vadapalli@...com>,
Jakub Kicinski <kuba@...nel.org>,
"David S . Miller" <davem@...emloft.net>,
Roger Quadros <rogerq@...nel.org>,
Ronald Wahl <ronald.wahl@...itan.com>
Subject: [PATCH] net: ethernet: ti: am65-cpsw: rx_pause/tx_pause controls wrong direction
From: Ronald Wahl <ronald.wahl@...itan.com>
The rx_pause flag says that whether we support receiving Pause frames.
When a Pause frame is received TX is delayed for some time. This is TX
flow control. In the same manner tx_pause is actually RX flow control.
Signed-off-by: Ronald Wahl <ronald.wahl@...itan.com>
---
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
index 24120605502f..ece9f8df98ae 100644
--- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
+++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
@@ -1588,10 +1588,10 @@ static void am65_cpsw_nuss_mac_link_up(struct phylink_config *config, struct phy
/* rx_pause/tx_pause */
if (rx_pause)
- mac_control |= CPSW_SL_CTL_RX_FLOW_EN;
+ mac_control |= CPSW_SL_CTL_TX_FLOW_EN;
if (tx_pause)
- mac_control |= CPSW_SL_CTL_TX_FLOW_EN;
+ mac_control |= CPSW_SL_CTL_RX_FLOW_EN;
cpsw_sl_ctl_set(port->slave.mac_sl, mac_control);
--
2.41.0
Powered by blists - more mailing lists