linux-kernel - Re: [PATCH] net: ethernet: ti: am65-cpsw: rx_pause/tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231104161052.GL891380@kernel.org>
Date:   Sat, 4 Nov 2023 12:10:52 -0400
From:   Simon Horman <horms@...nel.org>
To:     Ronald Wahl <rwahl@....de>
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        Grygorii Strashko <grygorii.strashko@...com>,
        Dan Carpenter <dan.carpenter@...aro.org>,
        Siddharth Vadapalli <s-vadapalli@...com>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Roger Quadros <rogerq@...nel.org>,
        Ronald Wahl <ronald.wahl@...itan.com>
Subject: Re: [PATCH] net: ethernet: ti: am65-cpsw: rx_pause/tx_pause controls
 wrong direction

On Tue, Oct 31, 2023 at 01:20:05PM +0100, Ronald Wahl wrote:
> From: Ronald Wahl <ronald.wahl@...itan.com>
> 
> The rx_pause flag says that whether we support receiving Pause frames.
> When a Pause frame is received TX is delayed for some time. This is TX
> flow control. In the same manner tx_pause is actually RX flow control.
> 
> Signed-off-by: Ronald Wahl <ronald.wahl@...itan.com>

Hi Ronald,

I am a little unclear if this patch addresses a user-visible bug, or
is adding a new feature.

If it is fixing a bug then it should be targeted at the net tree.
It should apply cleanly there, and the tree should be noted in the subject.

  Subject: [PATCH net] net: ethernet: ...

Also, if it is a bug fix, it should have a fixes tag, indicating the
revision(s) where the problem was introduced. This to assist in backporting
fixes. In this case perhaps the following is appropriate:

  Fixes: e8609e69470f ("net: ethernet: ti: am65-cpsw: Convert to PHYLINK")

It is probably not necessary to repost to address the above.
But please keep it in mind for future Networking patches.

On the other hand, if this is a new feature, then it should be targeted
at net-next:

  Subject: [PATCH net-next] net: ethernet: ...

And in that case the following applies.

## Form letter - net-next-closed

The merge window for v6.7 has begun and therefore net-next is closed
for new drivers, features, code refactoring and optimizations.
We are currently accepting bug fixes only.

Please repost when net-next reopens after November 12th.

RFC patches sent for review only are obviously welcome at any time.

See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle