linux-kernel - Re: [PATCH 2/2] drivers: rtc: max31335: initial commit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7cc209b6-c762-4cd2-bbac-bc6b0cc36166@roeck-us.net>
Date:   Tue, 31 Oct 2023 06:58:48 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     "Miclaus, Antoniu" <Antoniu.Miclaus@...log.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Jean Delvare <jdelvare@...e.com>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>
Subject: Re: [PATCH 2/2] drivers: rtc: max31335: initial commit

On 10/31/23 04:23, Miclaus, Antoniu wrote:
[ ... ]
>>> +	if (status != MAX31335_STATUS1_DEFAULT)
>>> +		dev_err_probe(&client->dev, -EINVAL,
>>> +			      "Unable to read from device.\n");
>>> +
>>
>> That is misleading. The device returned an unexpected status.
>> I don't know if this really reflects a problem, but it is not
>> "Unable to read from device".
>>
> 
> Since the device lacks an ID register, I found this as a suitable
> replacement for checking that the communication with the
> device actually works before the probe function finishes
> successfully.
> 

But the register read was successful. Also, why would you want to not
instantiate the driver if the chip runs on VBAT, if the oscillator
is running, if VBAT is low, or if some interrupt is pending for
some reason ?

Guenter