linux-kernel - RE: [PATCH 2/2] drivers: rtc: max31335: initial commit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY4PR03MB3399C30F209B2061EFC804C49BA0A@CY4PR03MB3399.namprd03.prod.outlook.com>
Date:   Tue, 31 Oct 2023 14:43:24 +0000
From:   "Miclaus, Antoniu" <Antoniu.Miclaus@...log.com>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
CC:     Guenter Roeck <linux@...ck-us.net>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Jean Delvare <jdelvare@...e.com>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>
Subject: RE: [PATCH 2/2] drivers: rtc: max31335: initial commit

> On 31/10/2023 11:23:49+0000, Miclaus, Antoniu wrote:
> > > > +	if (status != MAX31335_STATUS1_DEFAULT)
> > > > +		dev_err_probe(&client->dev, -EINVAL,
> > > > +			      "Unable to read from device.\n");
> > > > +
> > >
> > > That is misleading. The device returned an unexpected status.
> > > I don't know if this really reflects a problem, but it is not
> > > "Unable to read from device".
> > >
> >
> > Since the device lacks an ID register, I found this as a suitable
> > replacement for checking that the communication with the
> > device actually works before the probe function finishes
> > successfully.
> >
> > I will be more specific in the dev_err_probe message in the
> > upcoming patch version.
> >
> 
> What if this is a transient bus error and the device is actually present
> and working?
>  don't like this kind of check, they are not usually useful.
> 

Got it. Will drop the check in the next patch version.

> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://urldefense.com/v3/__https://bootlin.com__;!!A3Ni8CS0y2Y!9HB62f
> 1sSispWlqUtpamRif0eXxFGCqLzQD3KSwVl9t97YNev9s6akJCbWJ71dcIettiLkqz
> xyFpR_e8H_tCWl82OcBdHjBG$