linux-kernel - Re: [PATCH v2] scsi: ufs: ufs-sysfs: Expose UFS power info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e984ae48-5bc1-8bbb-b5cc-49832d789a47@quicinc.com>
Date:   Wed, 1 Nov 2023 11:52:31 +0800
From:   Can Guo <quic_cang@...cinc.com>
To:     Bart Van Assche <bvanassche@....org>, <mani@...nel.org>,
        <stanley.chu@...iatek.com>, <adrian.hunter@...el.com>,
        <beanhuo@...ron.com>, <avri.altman@....com>,
        <junwoo80.lee@...sung.com>, <martin.petersen@...cle.com>
CC:     <linux-scsi@...r.kernel.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Lu Hongfei <luhongfei@...o.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] scsi: ufs: ufs-sysfs: Expose UFS power info

Hi Bart,

On 11/1/2023 12:23 AM, Bart Van Assche wrote:
> On 10/31/23 02:53, Can Guo wrote:
>> +What: /sys/bus/platform/drivers/ufshcd/*/power_info/mode
>> +What:        /sys/bus/platform/devices/*.ufs/power_info/mode
>> +Date:        September 2023
>> +Contact:    Can Guo <quic_cang@...cinc.com>
>> +Description:    This file shows the UniPro power mode of UFS link:
>> +        == ====================================================
>> +        1   FAST_MODE
>> +        2   SLOW_MODE
>> +        4   FASTAUTO_MODE
>> +        5   SLOWAUTO_MODE
>> +        == ====================================================
>> +
>> +        The file is read only.
>
> For this attribute and the attributes below, shouldn't these be exported
> as text instead of as numbers? Shell scripts that read and use these
> attributes will be much easier to read if these attributes are changed
> from numeric into a textual.

Done.


Thanks,

Can Guo.

>
> Thanks,
>
> Bart.