linux-kernel - Re: [PATCH v2] mfd: intel-lpss: Fix IRQ check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231101104717.GH17433@black.fi.intel.com>
Date:   Wed, 1 Nov 2023 12:47:17 +0200
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Chen Ni <nichen@...as.ac.cn>, lee@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mfd: intel-lpss: Fix IRQ check

On Wed, Nov 01, 2023 at 11:38:28AM +0200, Andy Shevchenko wrote:
> On Wed, Nov 01, 2023 at 09:03:10AM +0200, Mika Westerberg wrote:
> > On Wed, Nov 01, 2023 at 06:26:43AM +0000, Chen Ni wrote:
> > > platform_get_irq() returns a negative error code to indicating an
> > > error. So in intel_lpss_probe() the unset / erroneous IRQ should be
> > > returned as is.
> > > 
> > > Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices")
> 
> > There is no need for Fixes tag here.
> 
> I said that already in v1 :-)
> 
> ...
> 
> > > -	if (!info || !info->mem || info->irq <= 0)
> > > +	if (!info || !info->mem)
> > 
> > This check (info->irq <= 0) covers both "invalid" interrupt numbers
> > (that's the negative errno and 0 as no interrupt) so I don't see how
> > this change makes it any better and the changelog does not clarify it
> > either.
> 
> It makes sense. The IRQ here may not be 0. We should actually fix
> the PCI code to guarantee that (platform_get_irq() guarantees that
> in platform driver).

Yeah but I mean the check above handles any "invalid" interrupt number
just fine regardless. I don't see any point changing that.