linux-kernel - Re: [PATCH v2] mfd: intel-lpss: Fix IRQ check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Nov 2023 14:38:31 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:     Chen Ni <nichen@...as.ac.cn>, lee@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mfd: intel-lpss: Fix IRQ check

On Wed, Nov 01, 2023 at 12:47:17PM +0200, Mika Westerberg wrote:
> On Wed, Nov 01, 2023 at 11:38:28AM +0200, Andy Shevchenko wrote:
> > On Wed, Nov 01, 2023 at 09:03:10AM +0200, Mika Westerberg wrote:
> > > On Wed, Nov 01, 2023 at 06:26:43AM +0000, Chen Ni wrote:

...

> > > > -	if (!info || !info->mem || info->irq <= 0)
> > > > +	if (!info || !info->mem)
> > > 
> > > This check (info->irq <= 0) covers both "invalid" interrupt numbers
> > > (that's the negative errno and 0 as no interrupt) so I don't see how
> > > this change makes it any better and the changelog does not clarify it
> > > either.
> > 
> > It makes sense. The IRQ here may not be 0. We should actually fix
> > the PCI code to guarantee that (platform_get_irq() guarantees that
> > in platform driver).
> 
> Yeah but I mean the check above handles any "invalid" interrupt number
> just fine regardless. I don't see any point changing that.

The point is to have proper error code to be returned. Currently it's shadowed
in this check.

-- 
With Best Regards,
Andy Shevchenko