linux-kernel - Re: [PATCH v2] coresight: etm4x: Fix width of CCITMIN field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3d744ee6-a739-42b6-8a87-124746a9287c@arm.com>
Date:   Wed, 1 Nov 2023 13:23:21 +0000
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     James Clark <james.clark@....com>, coresight@...ts.linaro.org,
        anshuman.khandual@....com, mike.leach@...aro.org
Cc:     stable@...r.kernel.org,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Pratik Patel <pratikp@...eaurora.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Kaixu Xia <xiakaixu@...wei.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] coresight: etm4x: Fix width of CCITMIN field

On 01/11/2023 11:52, James Clark wrote:
> CCITMIN is a 12 bit field and doesn't fit in a u8, so extend it to u16.
> This probably wasn't an issue previously because values higher than 255
> never occurred.
> 
> But since commit 0f55b43dedcd ("coresight: etm: Override TRCIDR3.CCITMIN
> on errata affected cpus"), a comparison with 256 was done to enable the
> errata, generating the following W=1 build error:
> 
>    coresight-etm4x-core.c:1188:24: error: result of comparison of
>    constant 256 with expression of type 'u8' (aka 'unsigned char') is
>    always false [-Werror,-Wtautological-constant-out-of-range-compare]
> 
>     if (drvdata->ccitmin == 256)
> 
> Cc: stable@...r.kernel.org
> Fixes: 2e1cdfe184b5 ("coresight-etm4x: Adding CoreSight ETM4x driver")
> Reviewed-by: Mike Leach <mike.leach@...aro.org>
> Signed-off-by: James Clark <james.clark@....com>

Thanks, applied to coresight next :


Suzuki