[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZUJRbI9ff83gH6Ng@valkosipuli.retiisi.eu>
Date: Wed, 1 Nov 2023 13:23:56 +0000
From: Sakari Ailus <sakari.ailus@....fi>
To: Alain Volmat <alain.volmat@...s.st.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Jacopo Mondi <jacopo.mondi@...asonboard.com>,
Kieran Bingham <kieran.bingham@...asonboard.com>,
Rob Herring <robh@...nel.org>, linux-media@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: media: i2c: add galaxycore,gc2145
dt-bindings
Hi Alain,
On Wed, Oct 11, 2023 at 07:57:29PM +0200, Alain Volmat wrote:
> Introduction of the Galaxy Core GC2145 XVGA CMOS camera sensor.
>
> Signed-off-by: Alain Volmat <alain.volmat@...s.st.com>
> ---
> .../bindings/media/i2c/galaxycore,gc2145.yaml | 104 ++++++++++++++++++
> 1 file changed, 104 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml
> new file mode 100644
> index 000000000000..94d194cf5452
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc2145.yaml
> @@ -0,0 +1,104 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/galaxycore,gc2145.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Galaxy Core 1/5'' UXGA CMOS Image Sensor
> +
> +maintainers:
> + - Alain Volmat <alain.volmat@...s.st.com>
> +
> +description:
> + The Galaxy Core GC2145 is a high quality 2 Mega CMOS image sensor, for mobile
> + phone camera applications and digital camera products. GC2145 incorporates a
> + 1616V x 1232H active pixel array, on-chip 10-bit ADC, and image signal
> + processor. It is programmable through an I2C interface. Image data is sent
> + either through a parallel interface or through MIPI CSI-2.
> +
> +allOf:
> + - $ref: ../video-interface-devices.yaml#
> +
> +properties:
> + compatible:
> + const: galaxycore,gc2145
> +
> + reg:
> + const: 0x3c
> +
> + clocks:
> + maxItems: 1
> +
> + powerdown-gpios:
> + maxItems: 1
> +
> + reset-gpios:
> + maxItems: 1
> +
> + iovdd-supply:
> + description: Power Supply for I/O circuits (1.7 - 3V).
> +
> + avdd-supply:
> + description: Power for analog circuit/sensor array (2.7 - 3V).
> +
> + dvdd-supply:
> + description: Power for digital core (1.7 - 1.9V).
> +
> + orientation: true
> +
> + rotation: true
> +
> + port:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + unevaluatedProperties: false
> +
> + required:
> + - endpoint
Could you add link-frequencies here, too?
> +
> + additionalProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - powerdown-gpios
> + - reset-gpios
> + - iovdd-supply
> + - avdd-supply
> + - dvdd-supply
> + - port
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + camera@3c {
> + compatible = "galaxycore,gc2145";
> + reg = <0x3c>;
> + clocks = <&clk_ext_camera>;
> + iovdd-supply = <&scmi_v3v3_sw>;
> + avdd-supply = <&scmi_v3v3_sw>;
> + dvdd-supply = <&scmi_v3v3_sw>;
> + powerdown-gpios = <&mcp23017 3 (GPIO_ACTIVE_LOW | GPIO_PUSH_PULL)>;
> + reset-gpios = <&mcp23017 4 (GPIO_ACTIVE_LOW | GPIO_PUSH_PULL)>;
> +
> + port {
> + endpoint {
> + remote-endpoint = <&mipid02_0>;
> + data-lanes = <1 2>;
> + };
> + };
> + };
> + };
> +
> +...
--
Kind regards,
Sakari Ailus
Powered by blists - more mailing lists