lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 1 Nov 2023 10:07:31 -0700
From:   Bart Van Assche <>
To:     Can Guo <>,,,,,,,
Cc:, Alim Akhtar <>,
        "James E.J. Bottomley" <>,
        Lu Hongfei <>,
        open list <>
Subject: Re: [PATCH v3] scsi: ufs: ufs-sysfs: Expose UFS power info

On 10/31/23 21:00, Can Guo wrote:
> +	return sysfs_emit(buf, "%s\n", hba->pwr_info.hs_rate ?
> +				       ufshcd_ufs_hs_gear_to_string(hba->pwr_info.gear_rx) :
> +				       ufshcd_ufs_pwm_gear_to_string(hba->pwr_info.gear_rx));
> +}

A nit: this is not how kernel code should be indented. I think that
"ufshcd_..." should be aligned with "buf,".


Reviewed-by: Bart Van Assche <>

Powered by blists - more mailing lists