lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 2 Nov 2023 09:48:58 +0800
From:   Can Guo <quic_cang@...cinc.com>
To:     Bart Van Assche <bvanassche@....org>, <mani@...nel.org>,
        <stanley.chu@...iatek.com>, <adrian.hunter@...el.com>,
        <beanhuo@...ron.com>, <avri.altman@....com>,
        <junwoo80.lee@...sung.com>, <martin.petersen@...cle.com>
CC:     <linux-scsi@...r.kernel.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Lu Hongfei <luhongfei@...o.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] scsi: ufs: ufs-sysfs: Expose UFS power info

Hi Bart,

On 11/2/2023 1:07 AM, Bart Van Assche wrote:
> On 10/31/23 21:00, Can Guo wrote:
>> +    return sysfs_emit(buf, "%s\n", hba->pwr_info.hs_rate ?
>> + ufshcd_ufs_hs_gear_to_string(hba->pwr_info.gear_rx) :
>> + ufshcd_ufs_pwm_gear_to_string(hba->pwr_info.gear_rx));
>> +}
>
> A nit: this is not how kernel code should be indented. I think that
> "ufshcd_..." should be aligned with "buf,".
>
> Anyway:
>
> Reviewed-by: Bart Van Assche <bvanassche@....org>


Will address it in next version.


Thanks,

Can Guo.

Powered by blists - more mailing lists