linux-kernel - Re: [PATCH RFC v2 3/3] cxl/memdev: Register for and process CPER events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6542ca25d2fb7_435c1294aa@iweiny-mobl.notmuch>
Date:   Wed, 1 Nov 2023 14:59:01 -0700
From:   Ira Weiny <ira.weiny@...el.com>
To:     Ira Weiny <ira.weiny@...el.com>,
        Smita Koralahalli <Smita.KoralahalliChannabasappa@....com>,
        Dan Williams <dan.j.williams@...el.com>,
        Jonathan Cameron <jonathan.cameron@...wei.com>
CC:     Yazen Ghannam <yazen.ghannam@....com>,
        Davidlohr Bueso <dave@...olabs.net>,
        Dave Jiang <dave.jiang@...el.com>,
        Alison Schofield <alison.schofield@...el.com>,
        Vishal Verma <vishal.l.verma@...el.com>,
        "Ard Biesheuvel" <ardb@...nel.org>, <linux-efi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-cxl@...r.kernel.org>
Subject: Re: [PATCH RFC v2 3/3] cxl/memdev: Register for and process CPER
 events

Ira Weiny wrote:
> Smita Koralahalli wrote:
> 

[snip]

> > I think we should copy into each 
> > field of struct cxl_event_record_hdr individually starting from length 
> > by pointer arithmetic (which is definitely bad, but I cannot think of a 
> > better way to do this) and then do memcpy for data field in struct 
> > cxl_event_record_raw..
> > 
> > Any other suggestions would be helpful as well.
> 
> Based on Dan's suggestion to share the structures this memcpy can be
> avoided altogether.  Let's see how that works.

memcpy was removed.

> 
> > 
> > I can make these changes and validate it on my end if that works..?
> 
> Any testing would be welcome.  I don't have a test setup readily
> available.

Sorry this took so long but I have a new series with the
headers/structures re-aranged along with the other changes.

https://lore.kernel.org/all/20230601-cxl-cper-v3-0-0189d61f7956@intel.com/

Thanks,
Ira