linux-kernel - Re: [PATCH] stacktrace: check whether task has a stack before saving it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZ2CXiNsnh_VxAy0OK+s_=cDqP8k0PVmNiL4QJ+mMZ+GQ@mail.gmail.com>
Date:   Wed, 1 Nov 2023 22:59:34 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Ronald Wahl <rwahl@....de>
Cc:     linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Ronald Wahl <ronald.wahl@...itan.com>
Subject: Re: [PATCH] stacktrace: check whether task has a stack before saving it

On Mon, Oct 30, 2023 at 6:59 PM Ronald Wahl <rwahl@....de> wrote:

> I encountered a crash on ARM32 when trying to dump the stack of some
> zombie process. This is caused by a missing check whether the task
> actually has a valid stack. This commit adds this check.
>
> Commit 214d8ca6ee85 ("stacktrace: Provide common infrastructure")
> introduced this check for platforms that define CONFIG_ARCH_STACKWALK
> but ARM32 is not one of them.
>
> Signed-off-by: Ronald Wahl <ronald.wahl@...itan.com>

Looks correct to me:
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij