linux-kernel - Re: [PATCH] regulator: core: Add option to prevent disabling unused regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875y2kh53h.fsf@minerva.mail-host-address-is-not-set>
Date:   Thu, 02 Nov 2023 10:33:38 +0100
From:   Javier Martinez Canillas <javierm@...hat.com>
To:     Mark Brown <broonie@...nel.org>,
        Manivannan Sadhasivam <mani@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Jonathan Corbet <corbet@....net>,
        Liam Girdwood <lgirdwood@...il.com>,
        "Paul E. McKenney" <paulmck@...nel.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        "Steven Rostedt (Google)" <rostedt@...dmis.org>,
        Tejun Heo <tj@...nel.org>, linux-doc@...r.kernel.org
Subject: Re: [PATCH] regulator: core: Add option to prevent disabling unused
 regulators

Mark Brown <broonie@...nel.org> writes:

> On Wed, Nov 01, 2023 at 10:26:52AM +0530, Manivannan Sadhasivam wrote:
>
>> On the other note, I'm wondering if we could use sync_state() for handling the
>> regulator_init_complete() work. This would ensure that the regulators are only
>> disabled when all the consumers are probed.
>
> That assumes that everything defined in the DT both has a driver and has
> the driver available for the currently running kernel neither of which
> is a good assumption.

Agreed. I believe the current logic of disabling all regulators using a
workqueue is the correct thing to do.

The only better option I think is to make user-space notify the kernel
that it won't load kernel modules anymore. But the delayed work would
sill be needed, since the kernel can't make an assumption on whether
user-space will notify of this or not.

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat