linux-kernel - Re: [PATCH v33 6/6] selftests: mm: add pagemap ioctl tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9abc532-2d56-4da9-a016-419e8ae57ac4@collabora.com>
Date:   Thu, 2 Nov 2023 16:49:41 +0500
From:   Muhammad Usama Anjum <usama.anjum@...labora.com>
To:     Ryan Roberts <ryan.roberts@....com>, Peter Xu <peterx@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Michał Mirosław 
        <emmir@...gle.com>, Andrei Vagin <avagin@...il.com>,
        Danylo Mocherniuk <mdanylo@...gle.com>,
        Paul Gofman <pgofman@...eweavers.com>
Cc:     Muhammad Usama Anjum <usama.anjum@...labora.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Shuah Khan <shuah@...nel.org>,
        Christian Brauner <brauner@...nel.org>,
        Yang Shi <shy828301@...il.com>,
        Vlastimil Babka <vbabka@...e.cz>,
        "Liam R . Howlett" <Liam.Howlett@...cle.com>,
        Yun Zhou <yun.zhou@...driver.com>,
        Suren Baghdasaryan <surenb@...gle.com>,
        Alex Sierra <alex.sierra@....com>,
        Matthew Wilcox <willy@...radead.org>,
        Pasha Tatashin <pasha.tatashin@...een.com>,
        Axel Rasmussen <axelrasmussen@...gle.com>,
        "Gustavo A . R . Silva" <gustavoars@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-mm@...ck.org, linux-kselftest@...r.kernel.org,
        Greg KH <gregkh@...uxfoundation.org>, kernel@...labora.com,
        Cyrill Gorcunov <gorcunov@...il.com>,
        Mike Rapoport <rppt@...nel.org>, Nadav Amit <namit@...are.com>,
        David Hildenbrand <david@...hat.com>
Subject: Re: [PATCH v33 6/6] selftests: mm: add pagemap ioctl tests

On 11/2/23 4:45 PM, Ryan Roberts wrote:
> On 21/08/2023 15:15, Muhammad Usama Anjum wrote:
> 
> [...]
> 
>> +
>> +
>> +int init_uffd(void)
>> +{
>> +	struct uffdio_api uffdio_api;
>> +
>> +	uffd = syscall(__NR_userfaultfd, O_CLOEXEC | O_NONBLOCK | UFFD_USER_MODE_ONLY);
>> +	if (uffd == -1)
>> +		ksft_exit_fail_msg("uffd syscall failed\n");
>> +
>> +	uffdio_api.api = UFFD_API;
>> +	uffdio_api.features = UFFD_FEATURE_WP_UNPOPULATED | UFFD_FEATURE_WP_ASYNC |
>> +			      UFFD_FEATURE_WP_HUGETLBFS_SHMEM;
>> +	if (ioctl(uffd, UFFDIO_API, &uffdio_api))
>> +		ksft_exit_fail_msg("UFFDIO_API\n");
>> +
>> +	if (!(uffdio_api.api & UFFDIO_REGISTER_MODE_WP) ||
>> +	    !(uffdio_api.features & UFFD_FEATURE_WP_UNPOPULATED) ||
>> +	    !(uffdio_api.features & UFFD_FEATURE_WP_ASYNC) ||
>> +	    !(uffdio_api.features & UFFD_FEATURE_WP_HUGETLBFS_SHMEM))
>> +		ksft_exit_fail_msg("UFFDIO_API error %llu\n", uffdio_api.api);
> 
> Hi,
> 
> I've just noticed that this fails on arm64 because the required features are not
> available. It's common practice to skip instead of fail for this sort of
> condition (and that's how all the other uffd tests work). The current fail
> approach creates noise in our CI.
> 
> I see this is already in mm-stable so perhaps we can add a patch to fix on top?
Yeah, we can add a patch to skip all the tests instead of failing here. Let
me send a patch this week.

> 
> Thanks,
> Ryan
> 
> 

-- 
BR,
Muhammad Usama Anjum