linux-kernel - Re: [Intel-gfx] [PATCH v3 01/15] drm/i915/dsi: assume BXT gpio works for non-native GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZUPfHhHOMqrBEFZZ@smile.fi.intel.com>
Date:   Thu, 2 Nov 2023 19:40:46 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Ville Syrjälä <ville.syrjala@...ux.intel.com>
Cc:     Jani Nikula <jani.nikula@...el.com>,
        intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, Hans de Goede <hdegoede@...hat.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Rodrigo Vivi <rodrigo.vivi@...el.com>,
        David Airlie <airlied@...il.com>
Subject: Re: [Intel-gfx] [PATCH v3 01/15] drm/i915/dsi: assume BXT gpio works
 for non-native GPIO

On Thu, Nov 02, 2023 at 07:10:09PM +0200, Ville Syrjälä wrote:
> On Thu, Nov 02, 2023 at 05:12:14PM +0200, Andy Shevchenko wrote:

...

> >  	if (native)
> >  		icl_native_gpio_set_value(dev_priv, gpio_number, value);
> >  	else if (DISPLAY_VER(dev_priv) >= 11)
> > -		icl_exec_gpio(connector, gpio_source, gpio_index, value);
> > +		bxt_exec_gpio(connector, gpio_source, gpio_index, value);
> 
> We could just drop this whole branch since we end up in bxt_exec_gpio()
> in the end anyway. Or we drop the final else and make this one check for
> DISPLAY_VER >=9.

Looking at the code, I'm not sure how we can get rid of it, but the second
option is feasible.

> >  	else if (IS_VALLEYVIEW(dev_priv))
> >  		vlv_exec_gpio(connector, gpio_source, gpio_number, value);
> >  	else if (IS_CHERRYVIEW(dev_priv))

-- 
With Best Regards,
Andy Shevchenko