linux-kernel - Re: [PATCH 02/10] ipmi: kcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231103143657.0000046f@Huawei.com>
Date:   Fri, 3 Nov 2023 14:36:57 +0000
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Andrew Jeffery <andrew@...econstruct.com.au>
CC:     <minyard@....org>, <openipmi-developer@...ts.sourceforge.net>,
        <linux-kernel@...r.kernel.org>, <aladyshev22@...il.com>,
        <jk@...econstruct.com.au>
Subject: Re: [PATCH 02/10] ipmi: kcs_bmc: Include spinlock.h

On Fri,  3 Nov 2023 16:45:14 +1030
Andrew Jeffery <andrew@...econstruct.com.au> wrote:

> struct kcs_bmc_device defines a spinlock member but the header in which
> it is defined failed to include the spinlock header. In the spirit of
> include-what-you-use, do what's necessary.
> 
> Signed-off-by: Andrew Jeffery <andrew@...econstruct.com.au>
This is fine, but whilst checking it I noticed there is no
forwards def of struct device or appropriate include.

Still that's unrelated
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>


> ---
>  drivers/char/ipmi/kcs_bmc.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/char/ipmi/kcs_bmc.h b/drivers/char/ipmi/kcs_bmc.h
> index fa408b802c79..880d835fb90c 100644
> --- a/drivers/char/ipmi/kcs_bmc.h
> +++ b/drivers/char/ipmi/kcs_bmc.h
> @@ -7,6 +7,7 @@
>  #define __KCS_BMC_H__
>  
>  #include <linux/list.h>
> +#include <linux/spinlock.h>
>  
>  #define KCS_BMC_EVENT_TYPE_OBE	BIT(0)
>  #define KCS_BMC_EVENT_TYPE_IBF	BIT(1)