linux-kernel - Re: [PATCH 03/10] ipmi: kcs_bmc: Make kcs_bmc_update_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Nov 2023 14:40:26 +0000
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Andrew Jeffery <andrew@...econstruct.com.au>
CC:     <minyard@....org>, <openipmi-developer@...ts.sourceforge.net>,
        <linux-kernel@...r.kernel.org>, <aladyshev22@...il.com>,
        <jk@...econstruct.com.au>
Subject: Re: [PATCH 03/10] ipmi: kcs_bmc: Make kcs_bmc_update_event_mask()
 static

On Fri,  3 Nov 2023 16:45:15 +1030
Andrew Jeffery <andrew@...econstruct.com.au> wrote:

> There were no users outside the subsystem core, so let's not expose it.
> 
> Signed-off-by: Andrew Jeffery <andrew@...econstruct.com.au>
Is it worth having the wrapper?

I guess all the other cases do have wrappers (even if that's because
they continue to be exported) so fair enough.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> ---
>  drivers/char/ipmi/kcs_bmc.c        | 11 +++++------
>  drivers/char/ipmi/kcs_bmc_client.h |  2 --
>  2 files changed, 5 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/char/ipmi/kcs_bmc.c b/drivers/char/ipmi/kcs_bmc.c
> index a429d9f8a7bf..1a827db8a465 100644
> --- a/drivers/char/ipmi/kcs_bmc.c
> +++ b/drivers/char/ipmi/kcs_bmc.c
> @@ -68,6 +68,11 @@ irqreturn_t kcs_bmc_handle_event(struct kcs_bmc_device *kcs_bmc)
>  }
>  EXPORT_SYMBOL(kcs_bmc_handle_event);
>  
> +static void kcs_bmc_update_event_mask(struct kcs_bmc_device *kcs_bmc, u8 mask, u8 events)
> +{
> +	kcs_bmc->ops->irq_mask_update(kcs_bmc, mask, events);
> +}
> +
>  int kcs_bmc_enable_device(struct kcs_bmc_device *kcs_bmc, struct kcs_bmc_client *client)
>  {
>  	int rc;
> @@ -178,12 +183,6 @@ void kcs_bmc_unregister_driver(struct kcs_bmc_driver *drv)
>  }
>  EXPORT_SYMBOL(kcs_bmc_unregister_driver);
>  
> -void kcs_bmc_update_event_mask(struct kcs_bmc_device *kcs_bmc, u8 mask, u8 events)
> -{
> -	kcs_bmc->ops->irq_mask_update(kcs_bmc, mask, events);
> -}
> -EXPORT_SYMBOL(kcs_bmc_update_event_mask);
> -
>  MODULE_LICENSE("GPL v2");
>  MODULE_AUTHOR("Haiyue Wang <haiyue.wang@...ux.intel.com>");
>  MODULE_AUTHOR("Andrew Jeffery <andrew@...id.au>");
> diff --git a/drivers/char/ipmi/kcs_bmc_client.h b/drivers/char/ipmi/kcs_bmc_client.h
> index 6fdcde0a7169..814ad8e052ef 100644
> --- a/drivers/char/ipmi/kcs_bmc_client.h
> +++ b/drivers/char/ipmi/kcs_bmc_client.h
> @@ -35,8 +35,6 @@ void kcs_bmc_unregister_driver(struct kcs_bmc_driver *drv);
>  int kcs_bmc_enable_device(struct kcs_bmc_device *kcs_bmc, struct kcs_bmc_client *client);
>  void kcs_bmc_disable_device(struct kcs_bmc_device *kcs_bmc, struct kcs_bmc_client *client);
>  
> -void kcs_bmc_update_event_mask(struct kcs_bmc_device *kcs_bmc, u8 mask, u8 events);
> -
>  u8 kcs_bmc_read_data(struct kcs_bmc_device *kcs_bmc);
>  void kcs_bmc_write_data(struct kcs_bmc_device *kcs_bmc, u8 data);
>  u8 kcs_bmc_read_status(struct kcs_bmc_device *kcs_bmc);